Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color greyscale colormap not being even #3391

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 21, 2023

What

Pointed out in #3373 that our grey colormap looked broken in the preview. When diving into it I got at first a scare about our color space pipeline being broken, but eventually I concluded that it was only the gray colormap which was broken.

Grey before/after with reference gradient from gimp:
fix
It's not perfectly equal to the reference, but then again the test wasn't executed with maximum vigor either. Some slight differences are to be expected due to the amount of conversions we need to go through to arrive at the final image.

(unchanged) turbo colormap gradient compared with the render from Matplot webpage (a bit sloppy but shows that we're definitely not some wild gamma converstion away from it!):
image

This affects all usages of the greyscale colormap.

Checklist

@Wumpf Wumpf added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself labels Sep 21, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% sure I made this fix before… maybe it was to color.rs (which is correct!)

@Wumpf Wumpf merged commit 3d4a6a5 into main Sep 21, 2023
28 of 31 checks passed
@Wumpf Wumpf deleted the andreas/fix-grayscale branch September 21, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants