Fix color greyscale colormap not being even #3391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pointed out in #3373 that our grey colormap looked broken in the preview. When diving into it I got at first a scare about our color space pipeline being broken, but eventually I concluded that it was only the gray colormap which was broken.
Grey before/after with reference gradient from gimp:
It's not perfectly equal to the reference, but then again the test wasn't executed with maximum vigor either. Some slight differences are to be expected due to the amount of conversions we need to go through to arrive at the final image.
(unchanged) turbo colormap gradient compared with the render from Matplot webpage (a bit sloppy but shows that we're definitely not some wild gamma converstion away from it!):
This affects all usages of the greyscale colormap.
Checklist